Imported MuTalk-Utilities #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Hi @DurieuxPol , could you do a little pass over this? Check my comments and let's discuss if there are questions
|
Made some changes following @guillep's requests. |
guillep
requested changes
Jan 25, 2024
| package: 'MuTalk-SpecUI' with: [ spec requires: #('MuTalk-Model') ]. | ||
| package: 'MuTalk-Tests' with: [ spec requires: #( 'MuTalk-Model' 'MuTalk-TestResources' 'MuTalk-Utilities' ) ]; | ||
| package: 'MuTalk-SpecUI' with: [ spec requires: #('MuTalk-Model') ]; | ||
| package: 'MuTalk-Utilities' with: [ spec requires: #( 'MuTalk-Model' ) ]. | ||
|
|
There was a problem hiding this comment.
Well now with the new package we sould add 'Mutalk-Utilities-Tests' in this Baseline! :)
guillep
reviewed
Jan 25, 2024
|
Perfect! Matrix tests are run by the CI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MuTalk-Utilities to MuTalk repository (from here).
MTMatrixis ready to use, I'll post a wiki page on it later.MTMutantOperatorAnalysisandMTMissingMutantOperatorAnalysismay need some polish and tests before being fully usable. I'll post wiki pages for them as well when ready.