Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored and renamed classes and methods for budgets #48

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

DurieuxPol
Copy link
Collaborator

@DurieuxPol DurieuxPol commented Dec 14, 2023

Fixes #41, fixes #42, fixes #43
Moved the empty code for start method of budgets in the superclass, with comments.
Rename all budgets classes to MTBudget. I could rename simply to Budget, but I kept the "MT" prefix to specify that those budgets are for mutation testing, and to avoid confusion in case there are other budgets from other projects, or in the future.
Renamed check: with: to exceedBudgetOn:considering: to be more intention revealing. Added comments as well.

@DurieuxPol DurieuxPol changed the title rename all mutation testing budget classes to MT budget classes, and … Moved repeated code of start in superclass, and rename MutationTestingBudget to MTBudget Dec 14, 2023
@coveralls
Copy link

coveralls commented Dec 14, 2023

Pull Request Test Coverage Report for Build 7223118904

  • 60 of 65 (92.31%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 60.329%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/MuTalk-TestResources/AuxiliarClassForMTBudget.class.st 0 1 0.0%
src/MuTalk-Model/MTBudget.class.st 16 20 80.0%
Totals Coverage Status
Change from base Build 7223074819: -0.03%
Covered Lines: 3846
Relevant Lines: 6375

💛 - Coveralls

@DurieuxPol DurieuxPol changed the title Moved repeated code of start in superclass, and rename MutationTestingBudget to MTBudget Refactored and renamed classes and methods for budgets Dec 15, 2023
Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Thanks!

@guillep guillep merged commit 2772c26 into pharo-contributions:master Dec 15, 2023
3 checks passed
@DurieuxPol DurieuxPol deleted the fix/4142 branch February 5, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants