Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to RandomMutantSelectionStrategyTest #46

Merged
merged 9 commits into from
Dec 15, 2023

Conversation

DurieuxPol
Copy link
Collaborator

Fixes #35, fixes #36, fixes #37
Reworked RandomMutantSelectionStrategyTest to have better tests. Added = method for MethodMutation in this regard.
Added as well hash method, so that two MethodMutation instances that are equal according to = have the same hash code (that was not the case before).

@coveralls
Copy link

coveralls commented Dec 14, 2023

Pull Request Test Coverage Report for Build 7223043196

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 55 of 55 (100.0%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.0%) to 60.361%

Files with Coverage Reduction New Missed Lines %
src/MuTalk-Model/MutationTestingAnalysis.class.st 4 61.44%
Totals Coverage Status
Change from base Build 7193015466: 1.0%
Covered Lines: 3851
Relevant Lines: 6380

💛 - Coveralls

@DurieuxPol DurieuxPol changed the title Update to RandomMutantSelectionStrategyTest Improvement to RandomMutantSelectionStrategyTest Dec 14, 2023
@DurieuxPol DurieuxPol changed the title Improvement to RandomMutantSelectionStrategyTest Improvements to RandomMutantSelectionStrategyTest Dec 14, 2023
Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pol, there are some improvements to do here before integration!

Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@guillep guillep merged commit e42f5ec into pharo-contributions:master Dec 15, 2023
3 checks passed
@DurieuxPol DurieuxPol deleted the fix/issues branch February 5, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants