Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added non-strict-mode that allows runs even with failing tests #29

Conversation

CarolinaMelendez
Copy link

This is my contribution to the issue #28

This implementation added an attribute

beStrictMode

Which by default is ´true´ but when set to ´false´ , it will display the information message.
" Your have {#} test(s) that have Errors or Failures. But in Non-Strict-Mode I will filter them "

And run taking in account only the passed tests.

@jordanmontt
Copy link
Collaborator

Hello, the code looks Ok. It would be better if you could add some tests to test this new feature.

@guillep
Copy link
Contributor

guillep commented Nov 20, 2023

Hi @CarolinaMelendez , thanks for the contribution!

Sorry I'm late, I just realized I was not getting notifications on this repo.

I agree with @jordanmontt , it would be nice to have a couple of tests on this (otherwise we would be reducing the mutation score of mutalk itself :)). Could you try writing one or two tests that check the the filtering works correctly?
It will, of course, be mostly a non-regression tests.

Thanks!
G

@guillep
Copy link
Contributor

guillep commented Feb 1, 2024

I don't think this is moving forward, I'm going to close it.

@DurieuxPol do you think this is implementable using test filters? #72

@guillep guillep closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants