-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example for the MuTalk chapter and small changes #121
Conversation
Salut @DurieuxPol there is a broken test in the P11 build, I re-ran it and it failed again, can you check it? The P9 build is broken because of a separate thing, we should fix it separately |
I think I found the issue. It's about this test: testWithNoTimeForMutantsRunsNoMutants
| duration analysisTime result |
"Divide duration by 4 to make sure we never have time for mutants"
duration := self fixedAnalysisTime / 4.
analysisTime := [ result := self runAnalysisForDuration: duration ]
timeToRun.
"We never treat mutants because the budget was exceeded running the initial test run, coverage analysis, etc"
self assert: result numberOfEvaluatedMutants equals: 0 When the test breaks it's because the analysis had time to evaluate mutants. The initial test run, coverage analysis etc don't always take the same time, and sometimes I guess it's way faster the 2nd time (when we compute analysisTime) than the 1st time (when we comput duration), so dividing by 4 is not always enough. |
And the issue doesn't seem to be specific to Pharo 11, I had it also on Pharo 12. It's just quite random given its nature. |
Hmm I think it's worth trying with a smaller time. But it's not a solution in the long term :) In the future if this persists and we don't find a solution maybe it's good to remove those tests? |
I'll do that. |
Thanks Pol! |
Package
MuTalk-Examples
contains a class and a test class used for the MuTalk chapter, and executable scripts as extension methods inMTAnalysis
class side.Small changes include :
mtAnalysis
inMTUtilityAnalysis
class