Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #88 Use pharmaversesdtm to host admiralpeds test data #115
Closes #88 Use pharmaversesdtm to host admiralpeds test data #115
Changes from all commits
0bb757c
9dd7346
d32b12e
5269047
d152cc9
d70eb0a
2aeca5a
7849bda
8d78898
5b88bf3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional to leave those columns blank (including
VSBLFL
), should we just remove this part and carry values over from the original VS data?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, should
VSBLFL
be replaced byVSLBOXFL
? In the SDTMIG it is stated thatVSBLFL
is kept only for backward compatibility. See also "4.5.9 Baseline Values" in the SDTMIG.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bundfussr want to make a separate issue on that one in this repo? as it would impact all VS (and any BDS) datasets, not just this peds one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see #119.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.