Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #246: NEST and pharmaverseadam collaboration post #264

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

manciniedoardo
Copy link
Collaborator

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Ensure your new post folder is of the form "posts/zzz_DO_NOT_EDIT_<your post title>". This is so that the post date can be auto-updated upon the merge into main.
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@manciniedoardo
Copy link
Collaborator Author

Happy for this one to be published in the second half of Jan. Just to note, I will be on leave from 23rd Dec until 15th Jan.


- __CI Integration and Automation__: On the [NEST](https://insightsengineering.github.io/nest/) side, new CI integration tests ensured that template updates were automatically verified against stored {pharmaverseadam} datasets. This maintained consistency and allowed developers to identify intended changes promptly.

- __Strategic Pipelines__: An automated pipeline was established to update {pharmaverseadam} datasets for each new release, reflecting any template changes accurately.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually not sure what this is telling me??

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow...this is very well-written...how do you find the time!!??

For my data blog - I was just like blah blah okay done.

I don't have much feedback as it flows very nicely and is super informative. I think the link package is really helpful here as so many packages are named-dropped.

Happy to see this published before we go holiday.

@manciniedoardo
Copy link
Collaborator Author

Wow...this is very well-written...how do you find the time!!??

For my data blog - I was just like blah blah okay done.

I don't have much feedback as it flows very nicely and is super informative. I think the link package is really helpful here as so many packages are named-dropped.

Happy to see this published before we go holiday.

credit goes to Joe Zhu who drafted it, I only reviewed and made into a post :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants