Closes #242

[pawelru]

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
• Ensure your new post folder is of the form "posts/zzz_DO_NOT_EDIT_<your post title>". This is so that the post date can be auto-updated upon the merge into main.
• Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
• Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up all tags for consistency.
• Add a short description for your blog post in the description field at the top of the markdown document.
• Blog post is short, personalized, reproducible and readable
• Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
  This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
• Address all merge conflicts and resolve appropriately
• Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
• Pat yourself on the back for a job well done! Much love to your accomplishment!

[pawelru]

Hmmm... It looks like the R/CICD.R does not complain but apparently CICD itself does. Do we use something else?

[manciniedoardo]

@pawelru we are having some issues with the spellcheck action, please ignore if all fine on your end.

[pawelru]

Hello reviewers! Hope you are doing well! I wanted to follow up on this PR to see if you might have a chance to review it. Please let me know if there's anything I can do to help!

[StefanThoma]

Hi Pawel, Thanks for the nudge, I’ll take a look tomorrow👍

…

On Wed, 9 Oct 2024 at 19:03, Pawel Rucki ***@***.***> wrote: Hello reviewers! Hope you are doing well! I wanted to follow up on this PR to see if you might have a chance to review it. Please let me know if there's anything I can do to help! — Reply to this email directly, view it on GitHub <#241 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJUWWEVK4JMXIQKKG4Y7Y6LZ2VOVVAVCNFSM6AAAAABPKFLP3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBSHA2TENRYG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[bms63]

Sorry @pawelru it looks good to me - ty for the poke. @StefanThoma can merge in once he finishes his review

[manciniedoardo]

Thanks for the reminder, Pawel. A couple of small comments for me.

On a wider note, if you've got open issues for development, it might be good to explicitly encourage people to contribute? You could welcome comments in the issues or in the slack channels etc.

[pawelru]

Thanks all the good comments! Asking for another round of review 🕺

[manciniedoardo]

LGTM

[StefanThoma]

It's really cool!
What would the placeholder for such an iframe be in the pdf version of the manual?
What does it look like when I look at the help page from the r console in rstudio, i.e. using ?function

[pawelru]

For pdf it would be just an empty space. It's in the docs here. If you are curious about implementation -> here

In the R console you can do the following:
? roxy.shinylive::create_shinylive_url -> it would open a manual of create_shinylive_url() which is also here
One can also do help("tag-examplesShinylive") to see this. I don't know how to open the latter via ? - that's why I encouraged the use of pkgdown help throughout the article.

I think I don't want to mention that here not to make it too detailed or become a technical writing. That's just to pitch an idea if you know what I mean

[StefanThoma]

Would be cool if you could answer the two questions in the post, otherwise cool package & post! :)

[StefanThoma]

CICD spell check worked on my side, I've added some words.

LGTM!

[manciniedoardo]

@pawelru all merged - please feel free to publicise your post as you see fit and we will re-share 😄