Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added google analytics tag #185

Merged
merged 4 commits into from
Aug 5, 2024
Merged

added google analytics tag #185

merged 4 commits into from
Aug 5, 2024

Conversation

gigikenneth
Copy link
Collaborator

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, add your own tag! We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we put some guidance in the readme with how/where to access the analytics? I have never looked at something like this before.

@manciniedoardo
Copy link
Collaborator

Thanks @gigikenneth, to view the analytics is it as simple as just going to the analytics link that was emailed to us?

@gigikenneth
Copy link
Collaborator Author

Thanks @gigikenneth, to view the analytics is it as simple as just going to the analytics link that was emailed to us?

Hi @manciniedoardo , exactly. After the pull request is merged, the numbers will go to Google Analytics and you can view it using the link you received. Other people can be added to Google Analytics as Viewers/Editors.

If we want the numbers to be open and accessible to anyone, then we'd have to make a dashboard, but that's probably overkill since we're about to start.

@manciniedoardo
Copy link
Collaborator

Thanks @gigikenneth, to view the analytics is it as simple as just going to the analytics link that was emailed to us?

Hi @manciniedoardo , exactly. After the pull request is merged, the numbers will go to Google Analytics and you can view it using the link you received. Other people can be added to Google Analytics as Viewers/Editors.

If we want the numbers to be open and accessible to anyone, then we'd have to make a dashboard, but that's probably overkill since we're about to start.

Happy to keep it as simple as possible, I don't think everyone needs access.

@StefanThoma
Copy link
Collaborator

Will we need a banner at the bottom informing the users about this, and asking for permission?
I think there may be some EU regulations regarding that.

@StefanThoma
Copy link
Collaborator

Will we need a banner at the bottom informing the users about this, and asking for permission? I think there may be some EU regulations regarding that.

hmmm:
https://chatgpt.com/share/39144168-069d-412d-ab3e-ced277905a76

@gigikenneth
Copy link
Collaborator Author

@StefanThoma , thank you for sharing, and yes, I agree we needed to ask for consent before proceeding. I'm looking at how we can do it in Quarto 👀

@StefanThoma
Copy link
Collaborator

@StefanThoma , thank you for sharing, and yes, I agree we needed to ask for consent before proceeding. I'm looking at how we can do it in Quarto 👀

I just asked GPT again, looks like it's possible:
https://chatgpt.com/share/223430c3-c804-4145-858b-f87b18de3217

- "express" consent so no tracking happens unless the blog visitors accept it.
- simple and light banner at the bottom right
- anonymizes IP addresses by default
@gigikenneth gigikenneth requested a review from bms63 July 29, 2024 09:27
@manciniedoardo manciniedoardo merged commit d185585 into main Aug 5, 2024
3 of 4 checks passed
@manciniedoardo manciniedoardo deleted the gigikenneth-patch-1 branch August 5, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants