Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #119 admiral filter functions #120

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Closes #119 admiral filter functions #120

merged 7 commits into from
Feb 23, 2024

Conversation

manciniedoardo
Copy link
Collaborator

Closes #119 - blog post about admiral filter functions

@bms63
Copy link
Collaborator

bms63 commented Feb 19, 2024

How did you whip this up so fast?!? Just did a quick pass.

What about linking the cheatsheet or even providing an image of the section that has the filter functions in them? Just to break up the wall of text and code.

Could you link to the function documentation in the first paragraph for each function/section.

Also can you link to admiral in the beginning?

I'll try and do a thorough read through tomorrow.

@manciniedoardo
Copy link
Collaborator Author

How did you whip this up so fast?!? Just did a quick pass.

speed-i-am-speed

What about linking the cheatsheet or even providing an image of the section that has the filter functions in them? Just to break up the wall of text and code.

Could you link to the function documentation in the first paragraph for each function/section.

Also can you link to admiral in the beginning?

Great suggestions, implemented, thanks!

manciniedoardo and others added 4 commits February 20, 2024 15:57
@manciniedoardo
#119 chore: spelling
c13127f
@bms63
Merge branch 'main' into 119_admiral_filter_fns
9638dee
@bms63
chore: merge in main and fix wordlist
3244386 
Merge remote-tracking branch 'origin/main' into 119_admiral_filter_fns

# Conflicts:
#	inst/WORDLIST.txt
@bms63
chore: fix wordlist
07c3fdb 
Merge branch '119_admiral_filter_fns' of https://github.com/pharmaverse/blog into 119_admiral_filter_fns

# Conflicts:
#	inst/WORDLIST.txt
@bms63 bms63 merged commit 80dbacf into main Feb 23, 2024
3 of 4 checks passed
@bms63 bms63 deleted the 119_admiral_filter_fns branch February 23, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanThoma StefanThoma Awaiting requested review from StefanThoma

@bms63 bms63 Awaiting requested review from bms63

@kaz462 kaz462 Awaiting requested review from kaz462

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blog Post: Short expository post on the admiral filter_* functions
2 participants
@manciniedoardo @bms63