-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closes #2 hex logo and various other updates from default admiraltemplate #11
Conversation
@bms63 @manciniedoardo a bunch more minor updates from the admiraltemplate defaults. let me know if you spot any others. FYI i did create #7 which catches some more needed for later once people dive into this. |
Description: A toolbox for programming Clinical Data Standards Interchange Consortium | ||
(CDISC) compliant Analysis Data Model (ADaM) datasets in R. ADaM datasets are a | ||
mandatory part of any New Drug or Biologics License Application submitted to the | ||
United States Food and Drug Administration (FDA). Analysis derivations are | ||
implemented in accordance with the "Analysis Data Model Implementation Guide" | ||
(CDISC Analysis Data Model Team, 2021, <https://www.cdisc.org/standards/foundational/adam/adamig-v1-3-release-package>). | ||
(CDISC Analysis Data Model Team, 2021, <https://www.cdisc.org/standards/foundational/adam>). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the year here? Wondering if we should drop that here and in other admiral packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes could probably be dropped - maybe best to have one person go through all and drop this in one go
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiralpeds (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()