-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove renv and other sundry items #1
Conversation
Probably should set up dev version of website and vbump stufff....ummm what else?? |
Thanks @bms63 - i'm a little out of date with all the latest admiral conventions here so i trust your updates and maybe @manciniedoardo could double check no others needed (same as for admiraltemplate PR: pharmaverse/admiraltemplate#72). Then I can focus on getting some pieces organised ahead of the kick-off, like a project board and some early issues or discussions for people to start contributing to. I did address the PR template update as you commented at pharmaverse/admiraltemplate#75 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a note about versioning and also a thought: would it be good to already put the admiralpeds hex in the repo so that it's available when the pkgdown site is updated?
- [ ] Address or fix all lintr warnings and errors - `lintr::lint_package()` | ||
- [ ] Run `R CMD check` locally and address all errors and warnings - `devtools::check()` | ||
- [ ] Link the issue in the Development Section on the right hand side. | ||
- [ ] Address all merge conflicts and resolve appropriately | ||
- [ ] Address all merge conflicts and resolve appropriately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to add a note about bumping the package version as well (see my comment in this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we should add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i made into separate issue - not entirely sure where to put it
No description provided.