Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renv and other sundry items #1

Merged
merged 11 commits into from
Feb 10, 2024
Merged

Remove renv and other sundry items #1

merged 11 commits into from
Feb 10, 2024

Conversation

bms63
Copy link
Collaborator

@bms63 bms63 commented Feb 8, 2024

No description provided.

@bms63
Copy link
Collaborator Author

bms63 commented Feb 8, 2024

Probably should set up dev version of website and vbump stufff....ummm what else??

@rossfarrugia
Copy link
Collaborator

Thanks @bms63 - i'm a little out of date with all the latest admiral conventions here so i trust your updates and maybe @manciniedoardo could double check no others needed (same as for admiraltemplate PR: pharmaverse/admiraltemplate#72). Then I can focus on getting some pieces organised ahead of the kick-off, like a project board and some early issues or discussions for people to start contributing to.

I did address the PR template update as you commented at pharmaverse/admiraltemplate#75

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a note about versioning and also a thought: would it be good to already put the admiralpeds hex in the repo so that it's available when the pkgdown site is updated?

- [ ] Address or fix all lintr warnings and errors - `lintr::lint_package()`
- [ ] Run `R CMD check` locally and address all errors and warnings - `devtools::check()`
- [ ] Link the issue in the Development Section on the right hand side.
- [ ] Address all merge conflicts and resolve appropriately
- [ ] Address all merge conflicts and resolve appropriately
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add a note about bumping the package version as well (see my comment in this PR)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we should add

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i made into separate issue - not entirely sure where to put it

Copy link

Code Coverage

Package Line Rate Health
admiralpeds 100%
Summary 100% (3 / 3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants