Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

204 admiral updates #213

Merged
merged 8 commits into from
Nov 23, 2023
Merged

204 admiral updates #213

merged 8 commits into from
Nov 23, 2023

Conversation

manciniedoardo
Copy link
Collaborator

Closes #204

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue so that it closes after successful merging.
  • Address all merge conflicts and resolve appropriately.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@manciniedoardo
Copy link
Collaborator Author

HI @palmenl @linacrer - since admiral has updated the derive_summary_records() function this require an update to the ADVFQ templates and vignettes. As you are not involved in admiraliophtha much these days I made the update myself but thought I would include you as reviewers so that you could both please double check the output still makes sense etc. Thanks!

Copy link

github-actions bot commented Nov 10, 2023

Code Coverage

Package Line Rate Health
admiralophtha 96%
Summary 96% (122 / 127)

@manciniedoardo
Copy link
Collaborator Author

@palmenl is this fine to merge?

Copy link
Collaborator

@palmenl palmenl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manciniedoardo all looks fine

@palmenl palmenl merged commit b5b6c05 into main Nov 23, 2023
16 of 17 checks passed
@palmenl palmenl deleted the 204_admiral_updates branch November 23, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General Issue: Review ahead of 1.0 release of admiral and admiralophtha
3 participants