git commit for 138_Add_OECAT_OESCAT@devel

[ukey1025]

Closes #138

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

• Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• Updated relevant unit tests or have written new unit tests - See Unit Test Guide
• If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• Update to all relevant roxygen headers and examples.
• Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• Address any updates needed for vignettes and/or templates
• Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
• Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• Address or fix all lintr warnings and errors - lintr::lint_package()
• Run R CMD check locally and address all errors and warnings - devtools::check()
• Link the issue so that it closes after successful merging.
• Address all merge conflicts and resolve appropriately.
• Pat yourself on the back for a job well done! Much love to your accomplishment!

[github-actions]

Package	Line Rate	Health
admiralophtha	96%	✔
Summary	96% (122 / 127)	✔

[manciniedoardo]

Hi @ukey1025 , Thanks for working on this. Please could you change the ADOE and ADBCVA vignettes in the vignettes folder also, in the same way that you did for these templates.

Regarding the checks that are failing: these are checks that verify whether your code is styled correctly. For the styler check, clicking on the failed check shows you can fix it by running styler::style_file("inst/templates/ad_adbcva.R") and saving the results. For the lintr check, this fails every time a line is longer than 100 characters long (it's deemed not very easy to read). But in your case I think the stuff you added works better on one line so I would just add a comment #nolint at the end of each of the long lines, like this:

"CSUBTH", "OPHTHALMIC ASSESSMENTS", "SD-OCT CST SINGLE FORM", "Study Eye", "SCSUBTH", "Study Eye Center Subfield Thickness (um)", 1, #nolint

so that the check doesn't fire.

Let me know if you need any help!