Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #4 - Updated admiral min version in description #10

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

AndersAskeland
Copy link
Member

@AndersAskeland AndersAskeland commented Jul 8, 2024

Closes #4

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral<ext> (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@AndersAskeland AndersAskeland changed the title chore: #4 Updated admiral min version to 1.1.0 Closes #4 - Updated admiral min version in description Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Code Coverage

Package Line Rate Health
admiralmetabolic 100%
Summary 100% (3 / 3)

@AndersAskeland AndersAskeland marked this pull request as ready for review July 8, 2024 11:38
@AndersAskeland
Copy link
Member Author

@manciniedoardo Out of curiosity, I've noticed that devtools::document() updated the RoxygenNote version recorded in the DESCRIPTION. I can't find any information across admiral of how to handle this update. Should it be updated when prompted, or kept at the current version?

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndersAskeland - please see my comment above. As this is your first PR can you also add yourself as an author in the DESCRIPTION file? See here for an example.

DESCRIPTION Outdated Show resolved Hide resolved
@manciniedoardo
Copy link
Collaborator

Thanks @AndersAskeland - please see my comment above. As this is your first PR can you also add yourself as an author in the DESCRIPTION file? See here for an example.

OK to leave - I think we updated the Roxygen version on admiral core recently and it's likely just percolating through.

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AndersAskeland

@manciniedoardo manciniedoardo merged commit 75fe77c into main Jul 8, 2024
15 checks passed
@manciniedoardo manciniedoardo deleted the 4_update_admiral_version branch July 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update admiral version in DESCRIPTION file
2 participants