Closes #393 Extra header line removed

[ddsjoberg]

This turns out to just be an extra line added by accident. The checks for # assert_integer_scalar ---- appear above this chunk.

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• Place Closes Bug: Incorrect assert_integer_scalar() test #393 into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• Address any updates needed for vignettes and/or templates
• Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
• Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• Address or fix all lintr warnings and errors - lintr::lint_package()
• Run R CMD check locally and address all errors and warnings - devtools::check()
• Link the issue in the Development Section on the right hand side.
• Address all merge conflicts and resolve appropriately
• Pat yourself on the back for a job well done! Much love to your accomplishment!

[github-actions]

Package	Line Rate	Health
admiraldev	95%	✔
Summary	95% (1099 / 1153)	✔

[bms63]

Something seems amiss here?

[ddsjoberg]

Something seems amiss here?

There were two sections for # assert_integer_scalar ----. Just deleting the second one that was out of place. Is there something else amiss @bms63 ?

[bms63]

This seems inccorrect - the integer and numeric stuff

[ddsjoberg]

ah, yes, the text needed to updated too

[bundfussr]

I think there are more issues. For example assert_character_scalar() is tested in tests 10 and 11 and 17-19. Similar for assert_data_frame(). Could we clean this up?

And there are some expect_error() calls which accept any error, e.g.,

expect_error(example_fun2(2))

in test 10. I think we should always specify the class argument for expect_error().

[ddsjoberg]

@bundfussr do you want to add those cleanups in this PR or another? If this PR, please feel free to push the updates here.

[bundfussr]

@bundfussr do you want to add those cleanups in this PR or another? If this PR, please feel free to push the updates here.

I can add them to this PR.

[bundfussr]

@bms63 , @ddsjoberg , I have cleaned up test-assertions.R. Now there shouldn't be more than one section per function and all expect_error() calls should use the class argument.

Could you double-check that I didn't miss anything or mess up something?

[bms63]

Thanks all!!

[bms63]

@ddsjoberg wasn't there a tracking issue for all the error messaging updates? I can't seem to find it

[ddsjoberg]

@ddsjoberg wasn't there a tracking issue for all the error messaging updates? I can't seem to find it

@bms63
There wasn't a master issue for all the updates. It was just a single issue listing the first round updates (#367)