Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2620: Update authors and acknowledgement ahead of 1.2 release #2621

Merged
merged 4 commits into from
Dec 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,11 @@ Authors@R: c(
person("Jeffrey", "Dickinson", role = "aut"),
person("Ross", "Farrugia", role = "aut"),
person("Fanny", "Gautier", role = "aut"),
person("G", "Gayatri", role = "aut"),
person("Asha", "Chakma", role = "aut"),
person("Dinakar", "Kulkarni", role = "aut"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Dinakar get moved to acknowledgements?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He still supports us so I'd keep

person("Edoardo", "Mancini", role = "aut",
comment = c(ORCID = "0009-0006-4899-8641")),
person("Sadchla", "Mascary", role = "aut"),
person("Gordon", "Miller", role = "aut"),
person("Lina", "Patil", role = "aut"),
person("Jim", "Rothstein", role = "aut",
comment = c(ORCID = "0009-0009-8659-6071")),
person("Sophie", "Shapcott", role = "aut"),
Expand All @@ -26,7 +23,6 @@ Authors@R: c(
person("Stefan", "Thoma", role = "aut",
comment = c(ORCID = "0000-0002-5553-9252")),
person("Phillip", "Webster", role = "aut"),
person("Kangjie", "Zhang", role = "aut"),
person("Zelos", "Zhu", role = "aut"),
person("F. Hoffmann-La Roche AG", role = c("cph", "fnd")),
person("GlaxoSmithKline LLC", role = c("cph", "fnd"))
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,4 @@ We use the following for support and communications between user and developer c

Along with the authors and contributors, thanks to the following people for their work on the package:

Jaxon Abercrombie, Mahdi About, Teckla Akinyi, James Black, Claudia Carlucci, Asha Chakma, Bill Denney, Kamila Duniec, Alice Ehmann, Romain Francois, Ania Golab, Alana Harris, Declan Hodges, Anthony Howard, Shimeng Huang, Samia Kabi, James Kim, John Kirkpatrick, Leena Khatri, Robin Koeger, Konstantina Koukourikou, Pavan Kumar, Pooja Kumari, Shan Lee, Wenyi Liu, Iain McCay, Jack McGavigan, Jordanna Morrish, Syed Mubasheer, Thomas Neitmann, Yohann Omnes, Barbara O'Reilly, Hamza Rahal, Nick Ramirez, Tom Ratford, Jim Rothstein, Sukalpo Saha, Tamara Senior, Sophie Shapcott, Ondrej Slama, Andrew Smith, Daniil Stefonishin, Vignesh Thanikachalam, Michael Thorpe, Annie Yang, Ojesh Upadhyay, Franciszek Walkowiak and Vladyslav Shuliar.
Jaxon Abercrombie, Mahdi About, Teckla Akinyi, James Black, Claudia Carlucci, Asha Chakma, Bill Denney, Kamila Duniec, Alice Ehmann, Romain Francois, G Gayatri, Ania Golab, Alana Harris, Declan Hodges, Anthony Howard, Shimeng Huang, Samia Kabi, James Kim, John Kirkpatrick, Leena Khatri, Robin Koeger, Konstantina Koukourikou, Pavan Kumar, Pooja Kumari, Shan Lee, Wenyi Liu, Iain McCay, Jack McGavigan, Jordanna Morrish, Syed Mubasheer, Thomas Neitmann, Yohann Omnes, Barbara O'Reilly, Lina Patil, Hamza Rahal, Nick Ramirez, Tom Ratford, Jim Rothstein, Sukalpo Saha, Tamara Senior, Sophie Shapcott, Vladyslav Shuliar, Ondrej Slama, Andrew Smith, Daniil Stefonishin, Steven Ting, Vignesh Thanikachalam, Michael Thorpe, Annie Yang, Ojesh Upadhyay, Franciszek Walkowiak and Kangjie Zhang.
10 changes: 8 additions & 2 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Alkalosis
Analyte
Ania
Aspartate
Asha
BDS
BILI
BLQ
Expand All @@ -60,6 +61,7 @@ CTCAEV
CTCAEv
CVD
Carlucci
Chakma
Cheatsheet
Chemistries
Chol
Expand Down Expand Up @@ -103,6 +105,7 @@ GRPID
GRPNAME
GSK
Gault
Gayatri
Gehan
GlaxoSmithKline
Glomerular
Expand Down Expand Up @@ -132,6 +135,7 @@ Jaxon
Jordanna
Kabi
Kamila
Kangjie
Khatri
Koeger
Konstantina
Expand Down Expand Up @@ -181,6 +185,7 @@ PARAMN
PLDOSE
PTT
Param
Patil
Pavan
Pharma
Pharmacokinetic
Expand Down Expand Up @@ -214,6 +219,7 @@ Saha
Samia
Shan
Shimeng
Shuliar
Slama
Stefonishin
Subperiod
Expand All @@ -240,11 +246,13 @@ USUBJID
USUBJIDs
Upadhyay
Vignesh
Vladyslav
WBC
Walkowiak
Wenyi
XXXXXXXX
Yohann
Zhang
admiralci
admiraldev
admiralonco
Expand Down Expand Up @@ -341,5 +349,3 @@ usethis
xULN
xportr
xpt
Vladyslav
Shuliar
4 changes: 0 additions & 4 deletions man/admiral-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading