-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2584 country_code_lookup moved to data #2614
Conversation
@@ -90,7 +90,7 @@ memory consumption. (#2590) | |||
<summary>Developer Notes</summary> | |||
|
|||
- Created unit tests for developer internal function `restricted_imputed_dtc_dt()` (#2495) | |||
- Adopted `data-raw/data` R Package Convention (#2427) | |||
- Adopted `data-raw/data` R Package Convention (#2427, #2584) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooohh i like this tack on to this news entry :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me! Nice to have the tests already making sure this works as intended.
Do any vignettes or examples use this? I guess they would of broken the checks anyways.
Yes, it's in vignette for Creating
Yes, it is in |
Co-authored-by: Stefan Bundfuss <[email protected]>
Co-authored-by: Stefan Bundfuss <[email protected]>
Looking at the pages built I noticed that another lookup table |
Thanks Jeff!! |
@jeffreyad could you just double check nothing warning-like is happening in the templates for these updates. the check only returns failure when an error happens. Thanks! |
Sure |
No issues with templates |
Thanks again @jeffreyad!! |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.md
for tracking developer-facing issues.pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()