Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2481 bug the result of derive param tte depends on the sort order of the input #2569

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
8e23388
Added order arguments to censor_source and event_source. Also added s…
ProfessorP-beep Nov 18, 2024
cd52801
Added order argument to tte_source as part of development and error f…
ProfessorP-beep Nov 18, 2024
2727736
Fixed previous erros but still need to address failed tests for Test …
ProfessorP-beep Nov 18, 2024
9e86217
added check_type arg_match to derive_param_tte so user has to input a…
ProfessorP-beep Nov 18, 2024
d97377c
Changed position of signal_duplicate_records function in derive_param…
ProfessorP-beep Nov 18, 2024
fa49a51
lintr changes by removing whitespace.
ProfessorP-beep Nov 18, 2024
01e8f5a
styler fix.
ProfessorP-beep Nov 18, 2024
53457c2
updated NEWS.md with changes to derive_param_tte,. Removed Test 17 fr…
ProfessorP-beep Nov 19, 2024
020c9d7
Merge branch 'main' into 2481-bug-the-result-of-derive_param_tte-depe…
ProfessorP-beep Nov 19, 2024
dccdbe1
changed the signal_duplicate_records within derive_parame_tte to hand…
ProfessorP-beep Nov 19, 2024
8006891
Merge branch '2481-bug-the-result-of-derive_param_tte-depends-on-the-…
ProfessorP-beep Nov 19, 2024
4c95243
added a tryCatch() to filter_date_sources to catch duplicates to addr…
ProfessorP-beep Nov 21, 2024
087c0f3
Moved duplication check to filter_date_sources in tryCatch() and rewr…
ProfessorP-beep Nov 24, 2024
4405868
1. Moved updates in News section to admiral dev section
ProfessorP-beep Dec 3, 2024
21b5a00
Ran styler, lintr fixes, and devtools check.
ProfessorP-beep Dec 3, 2024
ce07ad1
styler changes
ProfessorP-beep Dec 3, 2024
1d4e6b7
accepted snapshots from testthat and addressed bds_tte.Rmd error for …
ProfessorP-beep Dec 3, 2024
22f3f2d
added documentation for order and check_type arguments added to funct…
ProfessorP-beep Dec 3, 2024
47637a5
requested updates to documentation and test script for derive_param_tte
ProfessorP-beep Dec 16, 2024
e882758
corrected documentation and removed rlang from bds_tte.Rmd
ProfessorP-beep Dec 17, 2024
e5c28fc
updated derive_param_tte documentation and added test to derive_param…
ProfessorP-beep Dec 20, 2024
404c949
fixed spelling error
ProfessorP-beep Dec 20, 2024
ae70492
updates to derive_param_tte documentation and test examples.
ProfessorP-beep Dec 23, 2024
34d2fb3
Update NEWS.md
ProfessorP-beep Jan 8, 2025
65c58ee
Merge branch 'main' into 2481-bug-the-result-of-derive_param_tte-depe…
bms63 Jan 9, 2025
2a3cf6c
update to derive_param_tte test, function examples, and documentation.
ProfessorP-beep Jan 9, 2025
dbbb5ab
Merge branch '2481-bug-the-result-of-derive_param_tte-depends-on-the-…
ProfessorP-beep Jan 9, 2025
1cb81bc
snapshots accepted
ProfessorP-beep Jan 9, 2025
2aeaf29
passed local checks. Pushing again
ProfessorP-beep Jan 10, 2025
a95aa68
ran styler
ProfessorP-beep Jan 10, 2025
0a1d621
added "message" as a option for check_type in derive_var_obs_number
ProfessorP-beep Jan 10, 2025
e94e3eb
Update NEWS.md
ProfessorP-beep Jan 11, 2025
9980980
Merge branch 'main' into 2481-bug-the-result-of-derive_param_tte-depe…
bundfussr Jan 13, 2025
961bdbe
#2481: cosmetics
bundfussr Jan 13, 2025
82614e0
#2481: fix lintr
bundfussr Jan 13, 2025
cc777db
Merge branch 'main' into 2481-bug-the-result-of-derive_param_tte-depe…
bms63 Jan 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ target range. (#2571)
- Update `ADEG` template to flag `ABLFL` and `ANL01FL` based on `DTYPE == "AVERAGE"` records. (#2561)

## Updates of Existing Functions
- added `"message"` as option for `check_type` argument in `derive_var_obs_number` function. (#2481)
ProfessorP-beep marked this conversation as resolved.
Show resolved Hide resolved

- added `"message"` as option for `check_type` argument in `filter_extreme()` function. (#2481)

- Users can now specify how duplicate records are handled in `derive_param_tte()` using the `check_type` argument, with options including `"error"`, `"warning"`, `"message"`, or `"none"`, allowing for greater flexibility in managing duplicate data scenarios. (#2481)
Expand Down
2 changes: 1 addition & 1 deletion R/derive_var_obs_number.R
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ derive_var_obs_number <- function(dataset,
check_type <-
assert_character_scalar(
check_type,
values = c("none", "warning", "error"),
values = c("none", "warning", "error", "message"),
case_sensitive = FALSE
)

Expand Down
16 changes: 8 additions & 8 deletions man/derive_param_tte.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading