Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2510 enhance derive param computed #2544

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

#2510 enhance_derive_param_computed: fix links

d3742bb
Select commit
Loading
Failed to load commit list.
Open

Closes #2510 enhance derive param computed #2544

#2510 enhance_derive_param_computed: fix links
d3742bb
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Oct 30, 2024 in 0s

15 / 15 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update) Completed
Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files Completed
Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide Completed
If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance? Completed
Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.) Completed
Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family. Completed
Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately Completed
Address any updates needed for vignettes and/or templates Completed
Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues. Completed
Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page. Completed
Address or fix all lintr warnings and errors - lintr::lint_package() Completed
Run R CMD check locally and address all errors and warnings - devtools::check() Completed
Link the issue in the Development Section on the right hand side. Completed
Address all merge conflicts and resolve appropriately Completed
Pat yourself on the back for a job well done! Much love to your accomplishment! Completed
View more details on Task list completed