Closes #2501-general-issue-make-subject-keys-flexible-in-all-functions #2516
Conversation
…rs argument to use get_admiral_option("subject_keys"). Came across an issue during pkgdown checklist with bds_exposure.R lines 365-366 with !!!adsl_vars
…must've pulled by mistake.
Updated Functions and fixed an error when replacing UBSUBJID, STUDYID with get_admiral_options("Subject_keys)
…posure.Rmd line 365 but still get Argument `enexpr(analysis_var)` must be a <symbol>, but is missing.
…01-general-issue-make-subject-keys-flexible-in-all-functions
ProfessorP-beep
changed the title
…ct_keys"), CMREFID = FAREFID) to address symbol expression error.
…umn and formatting
|
My fault, I just had to update Rtools, and finding where errors in the test scripts that used the updated functions was easier. |
NEWS.md
Outdated
| - `derive_extreme_event()` was fixed such that `check_type = "none"` is accepted | ||
| again. (#2462) |
There was a problem hiding this comment.
This item shouldn't be moved to the upcoming release.
There was a problem hiding this comment.
Sorry, 1.1.0 or 1.1.1?
There was a problem hiding this comment.
This was implemented in 1.1.1. See https://pharmaverse.github.io/admiral/news/index.html.
| "P01", 3, | ||
| "P02", 31, | ||
| "P03", 42 | ||
| ~STUDYID, ~USUBJID, ~VAR1, |
There was a problem hiding this comment.
Could you align the columns (here and below)?
|
This Pull Request is stale because it has not been worked on in 15 days. |
|
Sorry, I'll get this fixed by the weekend. Work got hectic and preparing for an interview! |
…("subject_keys") for the bds_exposure vignette
|
I just noticed that after I run styler it misaligns the tables in the test scripts again. I can correct and we can just accept the failed styler check? |
Usually styler preserves alignment in tables if
I think when you aligned the tables you centered most of the columns. This is not considered as aligned by styler. |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptxand re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.mdfor tracking developer-facing issues.pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()