-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2427 general issue adopt data and data raw conventions #2494
Changes from 27 commits
11a337f
eaea9d6
95b4eca
2bd4290
f16131d
bd67872
05d16aa
f70b75e
6e41535
14e144b
c1d6cc1
732febc
b1c9ab5
4c75094
bd38b56
d50daa4
dceaca3
26e9313
4a6ecdf
8c7257d
aeaed83
d79b080
48f8934
dcf8719
1bcb848
f6aa82f
a5bb4f1
d89ce0c
ff67700
0076b24
873f163
1456d5e
cd5244b
678a46e
1323f8c
392cdfe
1850a8a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,3 +31,5 @@ | |
^\.devcontainer$ | ||
^vignettes/articles$ | ||
^inst/cheatsheet$ | ||
^data-raw$ | ||
^doc$ | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,3 +54,5 @@ admiral*.tgz | |
._.DS_Store | ||
|
||
.Rprofile | ||
/doc/ | ||
/Meta/ | ||
Comment on lines
+57
to
+58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need these? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess we can include, but why do we need them? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess this goes with the doc folder being igrnore in the build. Can we just remove the doc one please? What is the Meta for? |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
atoxgr_criteria <- system.file("adlb_grading/adlb_grading_spec.xlsx", package = "admiral") | ||
# Contrary to our usual convention the use of `::` here is explicit. This way we | ||
# avoid having to list {readxl} in "Imports" and instead get away with just | ||
# listing it in "Depends". | ||
|
||
atoxgr_criteria_ctcv4 <- atoxgr_criteria %>% | ||
readxl::read_excel(sheet = "NCICTCAEv4") %>% | ||
dplyr::mutate(GRADE_CRITERIA_CODE = gsub("[\r\n]", " ", GRADE_CRITERIA_CODE)) | ||
|
||
usethis::use_data(atoxgr_criteria_ctcv4, overwrite = TRUE) | ||
|
||
atoxgr_criteria_ctcv5 <- atoxgr_criteria %>% | ||
readxl::read_excel(sheet = "NCICTCAEv5") %>% | ||
dplyr::mutate(GRADE_CRITERIA_CODE = gsub("[\r\n]", " ", GRADE_CRITERIA_CODE)) | ||
|
||
use_data(atoxgr_criteria_ctcv5, overwrite = TRUE) | ||
|
||
atoxgr_criteria_daids <- atoxgr_criteria %>% | ||
readxl::read_excel(sheet = "DAIDS") %>% | ||
dplyr::mutate(GRADE_CRITERIA_CODE = gsub("[\r\n]", " ", GRADE_CRITERIA_CODE)) | ||
|
||
use_data(atoxgr_criteria_daids, overwrite = TRUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the
data-raw
here as it isn't part of R package structure.