Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2143 Loosen restrict_derivation() assertion #2164

Merged

Conversation

zdz2101
Copy link
Collaborator

@zdz2101 zdz2101 commented Oct 10, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (4386 / 4455)

@zdz2101
Copy link
Collaborator Author

zdz2101 commented Oct 10, 2023

Clone of PR here: #2144, but made a branch with an appropriate name to account for staged dependencies

@zdz2101 zdz2101 changed the title Test if staged dependencies stuff still works Closes #2143 Loosen restrict_derivation() assertion Oct 10, 2023
@zdz2101 zdz2101 marked this pull request as ready for review October 10, 2023 18:08
R/restrict_derivation.R Show resolved Hide resolved
@zdz2101 zdz2101 merged commit 095a4fd into main Oct 11, 2023
21 checks passed
@zdz2101 zdz2101 deleted the 2143_restrict_derivation_enhancement@339_enhanceassert_function branch October 11, 2023 15:46
@bundfussr
Copy link
Collaborator

@zdz2101 , I think we should have merged the PR in admiraldev first because now main is broken.

@zdz2101
Copy link
Collaborator Author

zdz2101 commented Oct 11, 2023

@zdz2101 , I think we should have merged the PR in admiraldev first because now main is broken.

Yes that was certainly my mistake, I went ahead and pushed all the proper updates to admiraldev and everything should go through now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants