-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2143 Loosen restrict_derivation()
assertion
#2164
Closes #2143 Loosen restrict_derivation()
assertion
#2164
Conversation
Merge branch 'main' into 2143_restrict_derivation_lighten_assertion # Conflicts: # DESCRIPTION # NEWS.md
…github.com/pharmaverse/admiral into 2143_restrict_derivation_lighten_assertion
Clone of PR here: #2144, but made a branch with an appropriate name to account for staged dependencies |
restrict_derivation()
assertion
@zdz2101 , I think we should have merged the PR in admiraldev first because now |
Yes that was certainly my mistake, I went ahead and pushed all the proper updates to |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()