Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2125 add true/false_value arguments for appropriate functions #2136

Merged
merged 37 commits into from
Oct 13, 2023
Merged

Closes #2125 add true/false_value arguments for appropriate functions #2136

merged 37 commits into from
Oct 13, 2023

Commits on Sep 27, 2023

  1. feat: #2125 intial draft of new truefalse val args

    Zelos Zhu committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    1831431 View commit details
    Browse the repository at this point in the history

  2. add word to globals

    Zelos Zhu committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    6c2bfea View commit details
    Browse the repository at this point in the history

  3. chore: #2125 address cicd checks

    Zelos Zhu committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    8d179bf View commit details
    Browse the repository at this point in the history

  4. feat: #2125 add test for t/f value for derive var extreme flag

    Zelos Zhu committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    85d89c0 View commit details
    Browse the repository at this point in the history

  5. feat: #2125 add test for derive_merged truefalse value

    Zelos Zhu committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    92bc048 View commit details
    Browse the repository at this point in the history

  6. chore: #2125 address rcmd error

    Zelos Zhu committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    b8e4f03 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. address errors

    Zelos Zhu committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    179283d View commit details
    Browse the repository at this point in the history

  2. address styler

    Zelos Zhu committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    48861ae View commit details
    Browse the repository at this point in the history

  3. feat: #2125 change default true/false to "Y"/NA

    Zelos Zhu committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d56b235 View commit details
    Browse the repository at this point in the history

  4. chore: #2125 add news blurb

    Zelos Zhu committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    de1306e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. catch up to main/address merge conflicts 

    Merge branch 'main' into 2125_add_truefalse_value_flags

# Conflicts:
#	NEWS.md
#	tests/testthat/test-derive_merged.R
    Zelos Zhu committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    03d93d6 View commit details
    Browse the repository at this point in the history

  2. address merge conflicts

    Zelos Zhu committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2d70d69 View commit details
    Browse the repository at this point in the history

  3. forgot to remove a snippet

    Zelos Zhu committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    8d27e82 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Merge branch 'main' into 2125_add_truefalse_value_flags

    @zdz2101
    zdz2101 authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2281ff5 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Merge branch 'main' into 2125_add_truefalse_value_flags

    @zdz2101
    zdz2101 authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b0f7f74 View commit details
    Browse the repository at this point in the history

  2. feat: #2125 add T/F values for derive_vars_joined as well

    Zelos Zhu committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    0274688 View commit details
    Browse the repository at this point in the history

  3. feat: #2125 align derive_extreme_records too and fix test suite

    Zelos Zhu committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    466cd05 View commit details
    Browse the repository at this point in the history

  4. did that fix it

    Zelos Zhu committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    15ea0f0 View commit details
    Browse the repository at this point in the history

  5. implications of this

    Zelos Zhu committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    729bef8 View commit details
    Browse the repository at this point in the history

  6. feat: #2125 add back exist_flag toggle

    Zelos Zhu committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d8cfbf4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into 2125_add_truefalse_value_flags

    @zdz2101
    zdz2101 authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    4f49476 View commit details
    Browse the repository at this point in the history

  8. update news blurb

    Zelos Zhu committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    bd50f22 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. fix the rlang stuff

    Zelos Zhu committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1ada1e6 View commit details
    Browse the repository at this point in the history

  2. less code modification

    Zelos Zhu committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c5a6ae2 View commit details
    Browse the repository at this point in the history

  3. add news blurb

    Zelos Zhu committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    18d4119 View commit details
    Browse the repository at this point in the history

  4. fix documentation

    Zelos Zhu committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f34ae89 View commit details
    Browse the repository at this point in the history

  5. feat: #2125 separate exist_flag and missing_value functionality

    Zelos Zhu committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    13ea0a6 View commit details
    Browse the repository at this point in the history

  6. super edge case to account for in feedback

    Zelos Zhu committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    9b4172f View commit details
    Browse the repository at this point in the history

  7. revert renaming of the temp flag for lookup

    Zelos Zhu committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    d7d2f0c View commit details
    Browse the repository at this point in the history

  8. run styler

    Zelos Zhu committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b384bcc View commit details
    Browse the repository at this point in the history

  9. cleaner code changes

    Zelos Zhu committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    92aaf07 View commit details
    Browse the repository at this point in the history

  10. lintr

    Zelos Zhu committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    368f4af View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. chore: #2125 change news blurb and fix deprecation messaging

    Zelos Zhu committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    90a77e3 View commit details
    Browse the repository at this point in the history

  2. cleaner to read

    Zelos Zhu committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    e3453e7 View commit details
    Browse the repository at this point in the history

  3. chore: #2125 use tmp var for derive_vars_merged_lookup

    Zelos Zhu committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    95e398d View commit details
    Browse the repository at this point in the history

  4. #2125 add_truefalse_value_flags: simplify code

    @bundfussr
    bundfussr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    458096b View commit details
    Browse the repository at this point in the history

  5. feat: #2125 styler & add test for deprecation warning

    Zelos Zhu committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    e2fb3ae View commit details
    Browse the repository at this point in the history