-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2115 - references to pharmaversesdtm and pharmaverse adam #2129
Conversation
…ected small typo.
README.md
Outdated
|
||
* Core package---one package containing all core functions required to create ADaMs, usable by any company (i.e. general derivations, utility functions and checks for ADSL, OCCDS and BDS) | ||
* TA (Therapeutic Area) package extensions---one package per TA with functions that are | ||
specific to algorithms and requirements for that particular TA (e.g. [`{admiralonco}`](https://pharmaverse.github.io/admiralonco/)) | ||
* Company package extensions---specific needs and plug-ins for the company, such as access to metadata | ||
(e.g. `{admiralroche}` or `{admiralgsk}`) | ||
|
||
## Related Data Packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we talk about xportr
, metacore
and metatools
for related ADaM needs?? Maybe sdtmchecks
or oak
could get a brief shout out??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added mention of xportr
, metacore
and metatools
- thanks for the suggestion. As this is in a "related ADaM needs" section I omitted mentioning sdtmchecks
and oak
which are more focused on SDTM.
Closes #2115 - added references to pharmaversesdtm and pharmaverse adam. Corrected small typo.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()