Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #1966 address derive_vars_joined bugs #2016

Merged
merged 17 commits into from
Aug 1, 2023
Merged

Closes #1966 address derive_vars_joined bugs #2016

merged 17 commits into from
Aug 1, 2023

Commits on Jul 19, 2023

  1. feat: #1966 make our check_type consistent

    Zelos Zhu committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    2fece95 View commit details
    Browse the repository at this point in the history

  2. feat: #1966 hacky solution to null new_vars .join problem

    Zelos Zhu committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    651168f View commit details
    Browse the repository at this point in the history

  3. chore: #1966 inserted line in wrong place

    Zelos Zhu committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    dceced5 View commit details
    Browse the repository at this point in the history

  4. feat: #1966 add news blurb for what was done

    Zelos Zhu committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    0507afd View commit details
    Browse the repository at this point in the history

  5. feat: #1966 add tests

    Zelos Zhu committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    99b3150 View commit details
    Browse the repository at this point in the history

  6. chore: #1966 lintr

    Zelos Zhu committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    e72dff5 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Merge branch 'devel' into 1966_bug_derive_vars_joined@devel

    @zdz2101
    zdz2101 authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    c70e684 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Merge branch 'devel' into 1966_bug_derive_vars_joined@devel

    @zdz2101
    zdz2101 authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    af81c6f View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. chore: #1966 swap appropriate order selection and restore check_type arg

    Zelos Zhu committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2ec4be5 View commit details
    Browse the repository at this point in the history

  2. Merge branch '1966_bug_derive_vars_joined@devel' of https://github.co… 

    …m/pharmaverse/admiral into 1966_bug_derive_vars_joined@devel
    Zelos Zhu committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9147ee7 View commit details
    Browse the repository at this point in the history

  3. chore: #1966 looks like that fixed it

    Zelos Zhu committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    7fe89d9 View commit details
    Browse the repository at this point in the history

  4. feat: #1966 issue warning for dataset_add naming conflicts when `new_… 

    …vars` is NULL
    Zelos Zhu committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    8c651dc View commit details
    Browse the repository at this point in the history

  5. chore: #1966 clean up for readability

    Zelos Zhu committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    bb9a17e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. chore: #1966 restore original replace_values_by_names

    Zelos Zhu committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    c67c8b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. chore: #1966 add additional test to demonstrate how order vars were f… 

    …ixed/selected
    Zelos Zhu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    05ea4ad View commit details
    Browse the repository at this point in the history

  2. feat: #1966 adopt feedback for error messaging of naming conflicts

    Zelos Zhu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    50701fd View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Merge branch 'devel' into 1966_bug_derive_vars_joined@devel

    @zdz2101
    zdz2101 authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a225fdf View commit details
    Browse the repository at this point in the history