Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1960 enhance derive_extreme_event() #2015

Merged
merged 30 commits into from
Aug 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
31ecb20
#1960 enhance_derive_extreme_event: start a draft
bundfussr Jul 13, 2023
92eead9
#1960 enhance_derive_extreme_event: continue draft
bundfussr Jul 13, 2023
ce03b2f
#1960 enhance_derive_extreme_event: continue draft
bundfussr Jul 17, 2023
9f5ac40
#1960 enhance_derive_extreme_event: add tests and documentation
bundfussr Jul 18, 2023
e3d009b
#1960 enhance_derive_extreme_event: update NEWS
bundfussr Jul 18, 2023
a592b92
#1960 enhance_derive_extreme_event: fix links
bundfussr Jul 18, 2023
246dd9f
#1960 enhance_derive_extreme_event: style files
bundfussr Jul 18, 2023
43b83df
Merge branch 'devel' into 1960_enhance_derive_extreme_event@devel
bundfussr Jul 18, 2023
45d182f
#1960 enhance_derive_extreme_event: add example
bundfussr Jul 19, 2023
1538ca1
#1960 enhance_derive_extreme_event: style files
bundfussr Jul 19, 2023
13ce88e
#1960 enhance_derive_extreme_event:add example and tests for event-sp…
bundfussr Jul 19, 2023
2931212
#1960 enhance_derive_extreme_event: add ignore_event_order argument
bundfussr Jul 20, 2023
f0b474e
#1960 enhance_derive_extreme_event: fix spelling
bundfussr Jul 20, 2023
36759c2
#1960 enhance_derive_extreme_event: use correct input dataset
bundfussr Jul 20, 2023
e05733e
Merge branch 'devel' into 1960_enhance_derive_extreme_event@devel
bundfussr Jul 24, 2023
eada7ba
#1960 enhance_derive_extreme_event: improve printing of event objects
bundfussr Jul 25, 2023
8001354
Merge branch 'devel' into 1960_enhance_derive_extreme_event@devel
bundfussr Aug 17, 2023
1843ead
#1960 enhance_derive_extreme_event: rename keep_vars_source to keep_s…
bundfussr Aug 17, 2023
cc103c5
#1960 enhance_derive_extreme_event: add description field
bundfussr Aug 18, 2023
86fc874
Merge branch 'devel' into 1960_enhance_derive_extreme_event@devel
bundfussr Aug 21, 2023
6186b89
Merge branch 'devel' into 1960_enhance_derive_extreme_event@devel
bms63 Aug 27, 2023
4b91296
#1960 enhance_derive_extreme_event: address QC comments
bundfussr Aug 30, 2023
2e5309d
#1960 enhance_derive_extreme_event: update man pages
bundfussr Aug 30, 2023
1ae5c48
Merge branch '1960_enhance_derive_extreme_event@devel' of github.com:…
bundfussr Aug 30, 2023
277ce3e
Merge branch 'devel' into 1960_enhance_derive_extreme_event@devel
bundfussr Aug 30, 2023
dcf2d7a
#1960 enhance_derive_extreme_event: remove docs/pkgdown.yml
bundfussr Aug 30, 2023
65f1c78
#1960 enhance_derive_extreme_event: style files
bundfussr Aug 30, 2023
7824052
chore: #1960 properly formatted testthat
Aug 30, 2023
fe6ae37
Merge branch 'devel' into 1960_enhance_derive_extreme_event@devel
bms63 Aug 30, 2023
ab3b8cf
chore: #1960 fix lint
Aug 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ export(desc)
export(dose_freq_lookup)
export(dthcaus_source)
export(event)
export(event_joined)
export(event_source)
export(exprs)
export(extend_source_datasets)
Expand Down
28 changes: 28 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## New Features

- `event_joined()` events were added. They can be specified for the `events`
argument in `derive_extreme_event()`. This allows to define events based on more
than one observation, e.g., events which need to be confirmed by a second
assessment. (#1960)

## Updates of Existing Functions
- The functions `derive_param_bmi()` and `derive_param_bsa()` are updated to have the option of producing more values at visits when only weight is collected (#1228).
- The functions `derive_var_age_years()` and `compute_age_years()` are updated to return an `NA` age in the case that the age unit is missing. (#2001) The argument `unit` for `derive_vars_aage()` is also changed to `age_unit` for consistency between these age-related functions. (#2025)
Expand All @@ -21,6 +26,29 @@
- Templates, vignettes, and other uses of `{admiral.test}` SDTM data are updated to use `{pharmaversesdtm}` instead. (#2040)


- `derive_extreme_event()` was enhanced (#1960):

- `event_joined()` events can be specified for the `events` argument. This
zdz2101 marked this conversation as resolved.
Show resolved Hide resolved
allows to define events based on more than one observation, e.g., events
which need to be confirmed by a second assessment.

- The `source_datasets` argument was added to the function and the
`dataset_name` field to `event()`. It can be used to define events based on
a different dataset than the input dataset.

- The `keep_source_vars` argument was added to the function and the
`keep_source_vars` field to `event()`. It allows to select which variables
should be kept for the selected observations.

- The `mode` and `order` field were added to `event()`. They allow to select
the first or last observation per by group if there are multiple observation
fulfilling the event condition.

- The `ignore_event_order` argument was added.

- The `description` field was added to `event()`. It can be used to provide
a description of the event in plain language.

## Breaking Changes
- The `compute_duration(type)` argument added the `"duration"` type calculation, and this is the new default (previously `"interval"` differences were returned). See function help file for details on the difference between `"duration"` and `"interval"` calculations. (#1875)

Expand Down
Loading
Loading