Closes #2595 deprecation of previous "superseded" functions #2615
Conversation
|
@bundfussr Question: How to set it up so I can use the admiraldev branch with the new deprecation function? |
|
For the workflows which use staged dependencies it should work with the branch naming you are using. For the snapshot workflows it will not work. We would need to update these workflows to enable it. However, I'm not sure if it is worth the effort. |
awesome thanks for confirming. wnated to make sure this was set up correctly before i started to update |
bms63
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…com/pharmaverse/admiral into 2595-deprecation@466-deprecation-20
…com/pharmaverse/admiral into 2595-deprecation@466-deprecation-20
…com/pharmaverse/admiral into 2595-deprecation@466-deprecation-20
|
Alright! Adventure is nearing the end. @ddsjoberg @manciniedoardo @bundfussr hoping you all can review please |
| x = "This message will turn into a warning with release of 1.3.0", | ||
| i = "https://pharmaverse.github.io/admiral/reference/derive_extreme_event.html" |
There was a problem hiding this comment.
I think I may have made this suggestion previously, but I wouldn't promise to the users the precise version when we're going to make deprecation message changes. We have a long deprecation cycle, and who knows if we need to change things in the future, e.g. we release v1.3 earlier than we had previously planned, or we wait longer. I recommend that before each release (and not just after a release), we search for all the deprecation messages in our package and update based on the deprecation calendar.
There was a problem hiding this comment.
You did! ummm.... maybe just "This message will turn into a warning at the next release"
I just want to stress to the user to start looking at updating their code.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptxand re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.mdfor tracking developer-facing issues.pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()