Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Issue: Move Superseded Functions to Deprecation Land and update Documentaion #2595

Open
bms63 opened this issue Dec 6, 2024 · 0 comments · May be fixed by #2615
Open

General Issue: Move Superseded Functions to Deprecation Land and update Documentaion #2595

bms63 opened this issue Dec 6, 2024 · 0 comments · May be fixed by #2615
Assignees
@bms63
Labels
general issue

Comments

@bms63
Copy link
Collaborator

bms63 commented Dec 6, 2024

Background Information

Gently release these functions to the after life

image

Definition of Done

  • Superseded functions Use new deprecation process
  • Unit Tests will be needed
  • Ensure Documentation reflects changes in our process
@bms63 bms63 self-assigned this Dec 6, 2024
@bms63 bms63 closed this as completed in bd7d21a Dec 13, 2024
@bms63 bms63 reopened this Dec 18, 2024
bms63 added a commit that referenced this issue Dec 18, 2024
@bms63
chore: #2595 renaming branch and attempt to use branch from admiraldev
06864ed
bms63 added a commit that referenced this issue Dec 19, 2024
@bms63
feat: #2595 use of new dep fcn
bcc0eff
bms63 added a commit that referenced this issue Dec 20, 2024
@bms63
test: #2595 snap those fingers!
15ba8a7
bms63 added a commit that referenced this issue Dec 20, 2024
@bms63
feat: #2595 deprecate date_source; tests: snapshot for inform message
d9e8a1c
bms63 added a commit that referenced this issue Dec 20, 2024
@bms63
chore: #2595 stlye me baby! withr for the win!
eba3885
bms63 added a commit that referenced this issue Dec 23, 2024
@bms63
tests: #2595 snapshots for inform messages for extreme_data fcns
5419517
bms63 added a commit that referenced this issue Dec 23, 2024
@bms63
tests: #2595 snapshots for get_summary_records; quiet messages for ot…
f66b567 
…her tests
bms63 added a commit that referenced this issue Dec 23, 2024
@bms63
feat: #2595 deprecate_inform now in date_source
15ea407
bms63 added a commit that referenced this issue Dec 23, 2024
@bms63
chore: #2595 styler - looking all fancy and dapper
3195e6d
@bms63 bms63 linked a pull request Dec 23, 2024 that will close this issue
Closes #2595 deprecation of previous "superseded" functions #2615
Open
15 tasks
@bms63 bms63 moved this from Priority to In Review in admiral (sdtm/adam, dev, ci, template, core) Jan 8, 2025
bms63 added a commit that referenced this issue Jan 8, 2025
@bms63
fix: #2595 msg for deprecate_inform; removed: deprecation for date_so…
c6bf09c 
…urce
bms63 added a commit that referenced this issue Jan 8, 2025
@bms63
chore: #2595 looking good feeling good
9385ab0
bms63 added a commit that referenced this issue Jan 9, 2025
@bms63
fix: #2595 implement findings from PR review
a6e6b93
bms63 added a commit that referenced this issue Jan 9, 2025
@bms63
chore: #2595 getting stylish for that release
d935cf8
bms63 added a commit that referenced this issue Jan 10, 2025
@bms63
fix: #2595 remove nocov from test lines
c4ba0bd
bms63 added a commit that referenced this issue Jan 10, 2025
@bms63
fix: #2595 incorrect subject for test
5f76d73
bms63 added a commit that referenced this issue Jan 10, 2025
@bms63
fix: #2595 align messaging to updated programming strategy
9b17140
bms63 added a commit that referenced this issue Jan 11, 2025
@bms63
chore: #2595 news indent
fa762af
bms63 added a commit that referenced this issue Jan 11, 2025
@bms63
chore: #2595 news entry
6062921
bms63 added a commit that referenced this issue Jan 11, 2025
@bms63
chore: #2595 adjust wording of message and update snapshots
2e875e2
bms63 added a commit that referenced this issue Jan 11, 2025
@bms63
docs: #2595 align messages to prog strat documentation
a526188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bms63 bms63

Labels
general issue
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2595 deprecation of previous "superseded" functions pharmaverse/admiral
1 participant
@bms63