Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Enhance derive_summary_records() and supersede get_summary_records() #2142

Closed
zdz2101 opened this issue Sep 28, 2023 · 0 comments · Fixed by #2158
Closed

Feature Request: Enhance derive_summary_records() and supersede get_summary_records() #2142

zdz2101 opened this issue Sep 28, 2023 · 0 comments · Fixed by #2158
Assignees
@zdz2101
Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness

Comments

@zdz2101
Copy link
Collaborator

zdz2101 commented Sep 28, 2023

Feature Idea

derive_summary_records() should be updated such that it can work with dataset_add, dataset_ref, missing values while deprecating the analysis_var and summary_fun arguments.

get_summary_records() can be superseded with the addition of dataset_add per conversation here

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response
@zdz2101 zdz2101 self-assigned this Sep 28, 2023
@zdz2101 zdz2101 added function re-work issues identified by function re-work gang - usually argument alignment, user friendliness and removed programming labels Sep 28, 2023
zdz2101 pushed a commit that referenced this issue Oct 6, 2023
feat: #2142 intiial superseding step
1b7e9ab
@zdz2101 zdz2101 linked a pull request Oct 6, 2023 that will close this issue
Closes #2142 Supersede get_summary_records() and enhance derive_summary_records() #2158
Merged
14 tasks
zdz2101 pushed a commit that referenced this issue Oct 24, 2023
feat: #2142 get a good clean slate
0e6ec6c
zdz2101 pushed a commit that referenced this issue Oct 26, 2023
feat: #2142 working enhanced function
346f595
zdz2101 pushed a commit that referenced this issue Oct 26, 2023
feat: #2142 add appropriate test suite
5a6263e
zdz2101 pushed a commit that referenced this issue Oct 26, 2023
feat: #2142 run styler, lintr, add news and roxygen documentation
843d852
zdz2101 pushed a commit that referenced this issue Oct 26, 2023
chore: #2142 spelling/grammar
2ea2c50
zdz2101 pushed a commit that referenced this issue Oct 26, 2023
chore: #2142 fix test
252e3c2
zdz2101 pushed a commit that referenced this issue Oct 27, 2023
chore: #2142 add remotes for admiraldev for proper branching strategy
7ba57b6
@manciniedoardo manciniedoardo mentioned this issue Oct 31, 2023
Closed
zdz2101 pushed a commit that referenced this issue Oct 31, 2023
chore: #2142 address feedback
053a419
zdz2101 added a commit that referenced this issue Nov 3, 2023
@zdz2101
feat: #2142 rename filter to filter_add
19ced77
zdz2101 added a commit that referenced this issue Nov 3, 2023
@zdz2101
feat: #2142 get checks appropriately running
53bdf63
zdz2101 added a commit that referenced this issue Nov 3, 2023
@zdz2101
chore: #2142 roxygen stuff
5c690f7
zdz2101 added a commit that referenced this issue Nov 6, 2023
@zdz2101
feat: #2142 clear up missing_values usage
eaf9892
zdz2101 added a commit that referenced this issue Nov 6, 2023
@zdz2101
chore: #2142 rename filter to filter_add internally in codebase too
5c3748a
zdz2101 added a commit that referenced this issue Nov 6, 2023
@zdz2101
chore: #2142 adopt and address all other feedback
89a673e
zdz2101 added a commit that referenced this issue Nov 7, 2023
@zdz2101
feat: #2142 remove extra fluff for missing values
b3fc993
zdz2101 added a commit that referenced this issue Nov 8, 2023
@zdz2101
chore: #2142 update documentation based on feedback
a0dc08a
zdz2101 added a commit that referenced this issue Nov 9, 2023
@zdz2101 @ddsjoberg
@jerryekohe @bms63
Closes #2142 Supersede get_summary_records() and enhance `derive_su…
205e0d1 
…mmary_records()` (#2158)

* feat: #2142 intiial superseding step

* rough draft without missing_values implementation

* rough draft of new enhancement

* feat: #2142 get a good clean slate

* feat: #2142 working enhanced function

* feat: #2142 add appropriate test suite

* feat: #2142 run styler, lintr, add news and roxygen documentation

* chore: #2142 spelling/grammar

* chore: #2142 fix test

* should we inform superseded

* retain deprecated arguments to pass cicd

* chore: #2142 add remotes for admiraldev for proper branching strategy

* min dev versioning

* Update DESCRIPTION

* chore: #2142 address feedback

* upversion our description page to match current version up on github

* docs: little note for running website versions

* feat: #2142 rename filter to filter_add

* Update R/derive_summary_records.R

Co-authored-by: Ben Straub <[email protected]>

* feat: #2142 get checks appropriately running

* roxygen stuff and vignettes

* chore: #2142 roxygen stuff

* get past check-templates

* finally get past templates

* feat: #2142 clear up missing_values usage

* chore: #2142 rename filter to filter_add internally in codebase too

* chore: #2142 adopt and address all other feedback

* missed a renaming

* feat: #2142 remove extra fluff for missing values

* update news blurb

* chore: #2142 update documentation based on feedback

---------

Co-authored-by: Zelos Zhu <[email protected]>
Co-authored-by: Daniel Sjoberg <[email protected]>
Co-authored-by: Jerry Johnson <[email protected]>
Co-authored-by: Ben Straub <[email protected]>
@manciniedoardo manciniedoardo mentioned this issue Nov 10, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdz2101 zdz2101

Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
1 participant
@zdz2101