#2563 no_list_columns: filter before check

pharmaverse · Dec 16, 2024 · c4aa56b · c4aa56b
1 parent f079644
commit c4aa56b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/R/derive_vars_transposed.R b/R/derive_vars_transposed.R
@@ -118,6 +118,8 @@ derive_vars_transposed <- function(dataset,
     optional = TRUE
   )
 
+  dataset_merge <- filter_if(dataset_merge, filter)
+
   # check for duplicates in dataset_merge as these will create list columns,
   # which is not acceptable for ADaM datasets
   signal_duplicate_records(
@@ -134,7 +136,6 @@ derive_vars_transposed <- function(dataset,
   )
 
   dataset_transposed <- dataset_merge %>%
-    filter_if(filter) %>%
     pivot_wider(
       names_from = !!key_var,
       values_from = !!value_var,

diff --git a/tests/testthat/test-derive_vars_transposed.R b/tests/testthat/test-derive_vars_transposed.R
@@ -40,6 +40,15 @@ test_that("derive_vars_transposed Test 2: filtering the merge dataset works", {
     "STUDY01", "P02",       31,    3,
     "STUDY01", "P03",       42,   NA
   )
+
+  dataset_merge <- tibble::tribble(
+    ~STUDYID,  ~USUBJID, ~TESTCD, ~VALUE,
+    "STUDY01", "P01",    "T01",       31,
+    "STUDY01", "P01",    "T02",        5,
+    "STUDY01", "P02",    "T01",        3,
+    "STUDY01", "P01",    "T02",        9
+  )
+
   actual_output <- derive_vars_transposed(
     dataset,
     dataset_merge,