Skip to content

Commit

Permalink
Closes #2563 no_list_columns: filter before check (#2611)
Browse files Browse the repository at this point in the history
* #2563 no_list_columns: add check to avoid list columns

* #2563 no_list_columns: update documentation

* #2563 no_list_columns: fix example and add see also

* #2563 no_list_columns: avoid package name prefix

* #2563 no_list_columns: update required admiraldev version

* #2563 no_list_columns: split files (and clean up tests)

* #2563 no_list_columns: update man

* #2563 no_list_columns: filter before check

---------

Co-authored-by: Daniel Sjoberg <[email protected]>
  • Loading branch information
bundfussr and ddsjoberg authored Dec 17, 2024
1 parent c038911 commit 4de1fb5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
3 changes: 2 additions & 1 deletion R/derive_vars_transposed.R
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ derive_vars_transposed <- function(dataset,
optional = TRUE
)

dataset_merge <- filter_if(dataset_merge, filter)

# check for duplicates in dataset_merge as these will create list columns,
# which is not acceptable for ADaM datasets
signal_duplicate_records(
Expand All @@ -134,7 +136,6 @@ derive_vars_transposed <- function(dataset,
)

dataset_transposed <- dataset_merge %>%
filter_if(filter) %>%
pivot_wider(
names_from = !!key_var,
values_from = !!value_var,
Expand Down
9 changes: 9 additions & 0 deletions tests/testthat/test-derive_vars_transposed.R
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@ test_that("derive_vars_transposed Test 2: filtering the merge dataset works", {
"STUDY01", "P02", 31, 3,
"STUDY01", "P03", 42, NA
)

dataset_merge <- tibble::tribble(
~STUDYID, ~USUBJID, ~TESTCD, ~VALUE,
"STUDY01", "P01", "T01", 31,
"STUDY01", "P01", "T02", 5,
"STUDY01", "P02", "T01", 3,
"STUDY01", "P01", "T02", 9
)

actual_output <- derive_vars_transposed(
dataset,
dataset_merge,
Expand Down

0 comments on commit 4de1fb5

Please sign in to comment.