Bug multiple analyte metabolite #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js3110
approved these changes
Feb 5, 2025
| sub_pknca_dose <- pknca_dose$data %>% | ||
| select(any_of(c(unname(unlist(pknca_dose$columns$groups)), | ||
| pknca_dose$columns$time, "DOSNO"))) %>% | ||
| rename_with(~ "time_dose", pknca_dose$columns$time) |
There was a problem hiding this comment.
Looks good to me, thanks! Small nitpick: could you add some comments to this section to make it easier to undesrtand the workflow :)
There was a problem hiding this comment.
nice I will add the comments and rebase your branch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #192
Description
There is a function that needs some adjustment (format_pkncadata_intervals) that accepts other more general input than PKNCAdose so we can easily cover the multiple analyte with metabolite case. Currently when the same drug is used for different analytes results will only be displayed for one of the analytes.
Definition of Done
DummyRO_with_metab.csvand running NCA with both analytes provides clear results with both analytesHow to test
Load DummyRO_with_metab.csv > Select both analytes > Choose whatever settings you prefer > Run NCA > Check if in results both analytes appear
Contributor checklist