Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: deload updating mydata from slope selector #185

refactor: modularize slope rules table

7e2dc7c
Select commit
Loading
Failed to load commit list.
Merged

Refactor: deload updating mydata from slope selector #185

refactor: modularize slope rules table
7e2dc7c
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2025-01-31 09:39:35 ago

0 / 5 tasks completed

5 tasks still to be completed

Details

Required Tasks

Task Status
Updates slope_selector so that it no longer updates mydata object. Apply button has been removed. Instead, the user should click on Run NCA in order to update the results, which is handled by nca.R. Incomplete
Adds warning stating that settings has been changed and the analysis must be re-run. Incomplete
In addition, table for viewing active selections/exclusions has been modularized and only updates when results have been recalculated. Incomplete
Code passes lintr checks Incomplete
Code passes all unit tests Incomplete
New logic covered by unit tests Incomplete
New logic is documented Incomplete
Package version is incremented Incomplete