Pavel test #21
Closed
Pavel test #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llrs-roche
reviewed
Feb 7, 2025
There was a problem hiding this comment.
This would try to render the report of the package on the directory where the package is installed. This will fail if it is installed with admin permissions and the user running it doesn't have them.
Also note that if the renaming part fails, we would get an obscure error message (or nothing).
Please, see the updated PR on #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@llrs-roche , with this change, I can finally render reports in my environment. But do you see any risks in it? I'm not deeply knowledgeable here.