refactor: add npm workspaces and update typescript settings

pharindoko · Aug 19, 2023 · 2021214 · 2021214
1 parent f2e6b80
commit 2021214
Show file tree

Hide file tree

Showing 9 changed files with 26,825 additions and 3,749 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -19,6 +19,9 @@
   "devDependencies": {
     "cz-conventional-changelog": "3.3.0"
   },
+  "workspaces": [
+    "packages/*"
+  ],
   "config": {
     "commitizen": {
       "path": "./node_modules/cz-conventional-changelog"

diff --git a/packages/server/package.json b/packages/server/package.json
@@ -80,5 +80,8 @@
     "commitizen": {
       "path": "./node_modules/cz-conventional-changelog"
     }
-  }
+  },
+  "files": [
+    "lib/**/*"
+  ]
 }
diff --git a/packages/server/tsconfig.json b/packages/server/tsconfig.json
@@ -1,21 +1,21 @@
 {
   "compilerOptions": {
-    "incremental": false,
+    "composite": true,
     "moduleResolution": "node",
     "module": "commonjs",
     "target": "ES2019",
-    "declaration": true,
     "esModuleInterop": true,
+    "declaration": true,
     "declarationMap": true,
     "outDir": "lib",
     "rootDir": "./src",
-    "composite": false,
     "strictPropertyInitialization": false,
     "noImplicitAny": false,
     "lib": ["es2015"],
     "sourceMap": false,
-    "resolveJsonModule": true
+    "resolveJsonModule": true,
+    "typeRoots": ["./node_modules/@types"]
   },
-  "include": ["src/**/*.ts"],
+  "include": ["src/**/*.ts", "src/validations/requestschema.json"],
   "exclude": ["tests"]
 }
diff --git a/packages/server/tsconfig.tsbuildinfo b/packages/server/tsconfig.tsbuildinfo
diff --git a/packages/template/package.json b/packages/template/package.json
@@ -11,7 +11,7 @@
   },
   "dependencies": {
     "express": "4.17",
-    "json-serverless-lib": "^1.6.16",
+    "json-serverless-lib": "file:../server",
     "serverless-http": "^2.6.0"
   },
   "devDependencies": {
@@ -37,4 +37,4 @@
     "package.json",
     "package-lock.json"
   ]
-}
+}
diff --git a/packages/template/serverless.yml b/packages/template/serverless.yml
@@ -21,15 +21,15 @@ custom:
 provider:
   stage: ${self:custom.file.stage, 'dev'}
   name: aws
-  runtime: nodejs18.x
+  runtime: nodejs16.x
   region: ${self:custom.region}
   stackName: ${self:custom.appconfig.stackName}
   stackTags: # Tags that will be added to each of the deployment resources
     jsonsls: ${self:custom.appconfig.stackName}
   environment:
     s3Bucket: ${self:custom.file.s3Bucket}
     s3File: ${self:custom.file.s3File}
-    basePath: /${self:custom.file.stage}
+    basePath: ${self:custom.file.stage}
     authPath: /jsonsls/${self:service}-${self:provider.stage}
     region: ${self:custom.region}
     AWS_NODEJS_CONNECTION_REUSE_ENABLED: 1

diff --git a/packages/template/src/handler.ts b/packages/template/src/handler.ts
@@ -26,7 +26,7 @@ const environment = new CloudEnvironment();
 const swagger = new Swagger(
   server,
   new SwaggerConfig(appConfig.readOnly, appConfig.enableApiKeyAuth),
-  `/${config.stage}`,
+  `/${environment.basePath}`,
   appConfig.routes.apiRoutePath,
   './package.json',
   appConfig.routes.swaggerSpecRoutePath

diff --git a/packages/template/tsconfig.json b/packages/template/tsconfig.json
@@ -12,8 +12,9 @@
     "strictPropertyInitialization": false,
     "noImplicitAny": false,
     "lib": ["es2015"],
-    "sourceMap": false,
-    "resolveJsonModule": true
+    "sourceMap": true,
+    "resolveJsonModule": true,
+    "typeRoots": ["./node_modules/@types"]
   },
   "include": ["src/**/*"]
 }