Merge pull request #12 from phar-io/feature/improve-uninstall

Check for write permissions before deleting phar
phar-io · Nov 23, 2020 · 47855ea · 47855ea
2 parents 2e7a530 + 48fdc1c
commit 47855ea
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/src/ConfiguredMediator.php b/src/ConfiguredMediator.php
@@ -47,14 +47,20 @@ private function removePhars(): void
 
         /** @var \PharIo\ComposerDistributor\File $phar */
         foreach ($config->phars() as $phar) {
-            $pharLocation = $binDir . DIRECTORY_SEPARATOR . $phar->pharName();
-            if (is_file($pharLocation)) {
-                $this->io->write(sprintf(
-                    'remove phar \'%1$s\'',
-                    $phar->pharName()
-                ));
-                unlink($pharLocation);
+            $this->deleteFile($phar, $binDir);
+        }
+    }
+
+    private function deleteFile(File $phar, string $binDir): void
+    {
+        $pharLocation = $binDir . DIRECTORY_SEPARATOR . $phar->pharName();
+        if (is_file($pharLocation)) {
+            if (!is_writable($pharLocation)) {
+                $this->io->write(sprintf('can not remove phar \'%1$s\' (insufficient permissions)', $phar->pharName()));
+                return;
             }
+            $this->io->write(sprintf('remove phar \'%1$s\'', $phar->pharName()));
+            unlink($pharLocation);
         }
     }
 }