Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify the AWS region #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paroga
Copy link

@paroga paroga commented Jan 1, 2025

Fixes #8

@mkgrgis
Copy link
Contributor

mkgrgis commented Jan 2, 2025

@paroga , what about regression tests? This pgspider FDW projects usually means time budget as 10-15% of coding, 65-80% of tests and 10-15% of discussing. Please refer testing and coding components in this commit as example.

@paroga
Copy link
Author

paroga commented Jan 2, 2025

@paroga , what about regression tests? This pgspider FDW projects usually means time budget as 10-15% of coding, 65-80% of tests and 10-15% of discussing. Please refer testing and coding components in this commit as example.

i don't see how this is testable with a local DynamoDB setup, but please feel free to suggest a good idea.

BTW: can you give me some insight on running the current tests in general? i'm not able to get the current ones running correctly on a current Debian and/or Alpine Linux distribution. What's the "correct" system to run the tests on? E.g. it looks like the error messages of curl do not match on my system: ERROR: dynamodb_fdw: failed to execute remote SQL: curlCode: 7, Couldn't connect to server vs. ERROR: dynamodb_fdw: failed to execute remote SQL: curlCode: 7, Could not connect to server (Couldn't vs Could not)

@mkgrgis
Copy link
Contributor

mkgrgis commented Jan 2, 2025

i don't see how this is testable with a local DynamoDB setup, but please feel free to suggest a good idea.

Just option test and SELECT from PostgreSQL information schema without any outer effects. This allows minimal ensure your contribution will exist after some future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to specify region
2 participants