Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for binary protocol for pcpatch #246

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

cyrilleberger
Copy link

This is an updated version of #85, with a test and update.

Two comments

  • the test requires /tmp/pgpointcloud_pa_test_file to be writable
  • the update to pg_type to install the pcpatch_send/pcpatch_recv functions is run even on new installation, which is unneeded (but harmless, as far as I know)

No idea on how to do differently and if it is a big problem.

@cyrilleberger
Copy link
Author

I was wondering, is anything else needed?

@cyrilleberger
Copy link
Author

Not entirely sure why the change I made would cause the errors, but if there is ever any interest in merging I could have a look.

@cyrilleberger
Copy link
Author

Formatting fixed, and updated to the latest master. "make check" is still passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant