style: simplify some statements for readability #1962

hamirmahal · 2024-12-15T23:42:03Z

Closes #1961

hamirmahal

I updated rustup to match the version in CI. This should fix failing formatting checks.

pgrx/src/datum/unbox.rs

pgrx-sql-entity-graph/src/aggregate/mod.rs

workingjubilee · 2024-12-18T00:09:09Z

Tests can be fixed with TRYBUILD=overwrite

hamirmahal force-pushed the style/simplify-some-statements-for-readability branch from f2221d7 to 064f167 Compare December 15, 2024 23:47

hamirmahal commented Dec 15, 2024

View reviewed changes

workingjubilee reviewed Dec 17, 2024

View reviewed changes

pgrx/src/datum/unbox.rs Outdated Show resolved Hide resolved

hamirmahal force-pushed the style/simplify-some-statements-for-readability branch from 064f167 to 16a789f Compare December 17, 2024 22:50

workingjubilee requested changes Dec 18, 2024

View reviewed changes

pgrx-sql-entity-graph/src/aggregate/mod.rs Outdated Show resolved Hide resolved

hamirmahal added 3 commits December 18, 2024 13:25

style: skip formatting for type As<'src>

0af8448

style: simplify some statements for readability

7360e91

fix: formatting for .rs files

e7fd0ef

hamirmahal force-pushed the style/simplify-some-statements-for-readability branch from 16a789f to e7fd0ef Compare December 18, 2024 22:00

TRYBUILD=overwrite cargo test --features pg14

8183edb

hamirmahal requested a review from workingjubilee December 25, 2024 20:38

workingjubilee approved these changes Dec 28, 2024

View reviewed changes

workingjubilee merged commit e169887 into pgcentralfoundation:develop Dec 28, 2024
14 checks passed

hamirmahal deleted the style/simplify-some-statements-for-readability branch December 28, 2024 08:05

Provide feedback