Satisfy clippy errors on 7 of 8 crates #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to run clippy on everything else.
Refactors a loop into a closure to do so, winning back some indents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does more cleanup in the vein of weakening needless bounds.
However, the "main point" is some no-op "make clippy happy" refactoring. This permits running
cargo clippywithout getting errors (it still issues literally hundreds of warnings) on most of the repository's crates. It does not solve this forpgrxitself, as clippy detected a more serious issue there, and that issue is instead its own PR:clippy -Awarningsto CI and fix unsound fn #1357