Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to run against Ruby 3.3, drop Ruby 2.6 #312

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

owst
Copy link

@owst owst commented Mar 6, 2024

`google-protobuf` [supports Ruby 3.3 in platform-specific versions of 3.25.3](https://rubygems.org/gems/google-protobuf/versions/3.25.3-x86_64-linux)

Some discussion in this thread: protocolbuffers/protobuf#15336 (comment)
@lfittl
Copy link
Member

lfittl commented Mar 7, 2024

@owst Thanks for the contribution!

Looks like we do also need to bump up protobuf (at least a bit) to get this to work? (see failing CI)

@owst
Copy link
Author

owst commented Mar 7, 2024

Oops, thanks for the ping @lfittl - I think my eyes read the gemspec requirement as already being >= 3.25.3 rather than >= 3.22.3 🤦

@owst
Copy link
Author

owst commented Mar 7, 2024

Hmm, it looks like google-protobuf-3.25.3 doesn't support Ruby 2.6 (which is EOL) - I guess it's time to drop support for 2.6 in pg_query.

N.B. 2.7 is also EOL I wonder if by dropping support rubocop could be updated from its ancient version so it doesn't need to be skipped on PRs

@owst owst changed the title Update CI to run against Ruby 3.3 Update CI to run against Ruby 3.3, drop Ruby 2.6 Mar 7, 2024
@Uaitt
Copy link

Uaitt commented Aug 14, 2024

@lfittl any update on this?

For me it would make sense to drop support for Ruby 2.6, 2.7 and 3.0 since they are all EOL.

Additionally, I would consider adding a tool like Dependabot so that dependencies are not left too much behind here and so that we don't need to manually update them when needed.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants