Protobuf generation: Correctly include $ ASCII_36 token #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally only modified in the output file, not in the generation logic itself.
lfittl
referenced
this pull request
Nov 20, 2023
Postgres's scanner will scan $ into a single token. For example:
SELECT $identifier;
The parser will later reject this. However, since the scanner returns
this value, we should define a Token for it in the protobuf.
test/scan.c:
* Add a check so the test does not crash if token_kind is NULL, which
it was before I defined the token. The test now prints an error:
INVALID result for "...": scan_result token 1 token_kind == NULL
* Make tests constant to prevent accidental modification. Unnecessary
but could be helpful.
* Define testsCount automatically so it no longer needs to be changed.
* Add an assert to help ensure tests are defined correctly.
keiko713
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally only modified in the output file, not in the generation logic itself.