Deparser: Add support for COALESCE and other expressions in LIMIT clause #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've previously supported "c_expr" being used in a LIMIT clause, but its actually more correct to treat this as "a_expr", which is a broader set of functions, including COALESCE. Note that the previous handling (for "c_expr") is still correct for FETCH FIRST (expr) ROWS WITH TIES, see the "select_fetch_first_value" in the Postgres grammar. In passing fix two new warnings in the deparser caused by a recent code addition.
msepga
approved these changes
Aug 4, 2023
msepga
added a commit
that referenced
this pull request
Aug 4, 2023
msepga
added a commit
that referenced
this pull request
Aug 4, 2023
* Fix builds on glibc >= 2.38 `glibc` now defines `strchrnul`, so we add a check to see if `glibc` is being used, and instead import the symbol if so. * Bump version to 4.2.3 * Add note about PR #199 in 4.2.3 changelog
longqimin
pushed a commit
to longqimin/libpg_query
that referenced
this pull request
Nov 20, 2023
* Fix builds on glibc >= 2.38 `glibc` now defines `strchrnul`, so we add a check to see if `glibc` is being used, and instead import the symbol if so. * Bump version to 4.2.3 * Add note about PR pganalyze#199 in 4.2.3 changelog
longqimin
pushed a commit
to longqimin/libpg_query
that referenced
this pull request
Nov 21, 2023
…use (pganalyze#199) We've previously supported "c_expr" being used in a LIMIT clause, but its actually more correct to treat this as "a_expr", which is a broader set of functions, including COALESCE. Note that the previous handling (for "c_expr") is still correct for FETCH FIRST (expr) ROWS WITH TIES, see the "select_fetch_first_value" in the Postgres grammar. In passing fix two new warnings in the deparser caused by a recent code addition.
longqimin
pushed a commit
to longqimin/libpg_query
that referenced
this pull request
Nov 21, 2023
* Fix builds on glibc >= 2.38 `glibc` now defines `strchrnul`, so we add a check to see if `glibc` is being used, and instead import the symbol if so. * Bump version to 4.2.3 * Add note about PR pganalyze#199 in 4.2.3 changelog
fantix
pushed a commit
to fantix/libpg_query
that referenced
this pull request
Jul 12, 2024
* Fix builds on glibc >= 2.38 `glibc` now defines `strchrnul`, so we add a check to see if `glibc` is being used, and instead import the symbol if so. * Bump version to 4.2.3 * Add note about PR pganalyze#199 in 4.2.3 changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've previously supported "c_expr" being used in a LIMIT clause, but its actually more correct to treat this as "a_expr", which is a broader set of functions, including COALESCE.
Note that the previous handling (for "c_expr") is still correct for FETCH FIRST (expr) ROWS WITH TIES, see the "select_fetch_first_value" in the Postgres grammar.
In passing fix two new warnings in the deparser caused by a recent code addition.