Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CREATE SUBSCRIPTION's generated query for copy_data parameter when it is set to false. #6817 #6889

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

anilsahoo20
Copy link
Contributor

No description provided.

@anilsahoo20
Copy link
Contributor Author

In the CREATE subscription dialog->WITH tab,

Issue:
Initially create_slot is true, In connection tab-> once we put host name as localhost, create_slot becomes false, as the host name and port are same as server where the subscription we are creating, but once you change the port, still create_slot remains false.

Expected Result:
create_slot value is by default true, but if the host name and port are same for both publication and subscription, then create_slot will be false as the slot is not needed, because of same server, but if the host and port are different for publication and subscription, the create_slot need to be true.

@adityatoshniwal adityatoshniwal merged commit 6062084 into pgadmin-org:master Nov 3, 2023
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants