Skip to content

Commit

Permalink
Fix issues found during testing. #6229, #6836
Browse files Browse the repository at this point in the history
  • Loading branch information
adityatoshniwal committed Oct 12, 2023
1 parent 10adb6a commit 3a62fc5
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
1 change: 1 addition & 0 deletions docs/en_US/release_notes_7_8.rst
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Bug fixes

| `Issue #4995 <https://github.com/pgadmin-org/pgadmin4/issues/4995>`_ - Fixed an issue in ERD tool where the downloaded images have a few links cut.
| `Issue #5749 <https://github.com/pgadmin-org/pgadmin4/issues/5749>`_ - Fixed an issue where user was not able to assign new/old columns as primary key once column with primary key is deleted.
| `Issue #6285 <https://github.com/pgadmin-org/pgadmin4/issues/6285>`_ - Add support for setting prepare threshold in server connection.
| `Issue #6482 <https://github.com/pgadmin-org/pgadmin4/issues/6482>`_ - Fixed an issue where the wrong message "Current database has been moved or renamed" is displayed when debugging any function.
| `Issue #6538 <https://github.com/pgadmin-org/pgadmin4/issues/6538>`_ - Fixed an issue where Processes tab displays wrong server name in some scenario.
| `Issue #6579 <https://github.com/pgadmin-org/pgadmin4/issues/6579>`_ - Fix an issue where global/native keyboard shortcuts are not working when any cell of data output grid has focus.
Expand Down
4 changes: 2 additions & 2 deletions web/pgadmin/browser/server_groups/servers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,7 @@ def create_shared_server(data, gid):
db.session.delete(shared_server)
db.session.commit()

current_app.logger.exception(e)
return internal_server_error(errormsg=str(e))
raise e

@staticmethod
def get_shared_server(server, gid):
Expand Down Expand Up @@ -1203,6 +1202,7 @@ def create(self, gid):
False) else 0,
tunnel_identity_file=data.get('tunnel_identity_file', None),
shared=data.get('shared', None),
shared_username=data.get('shared_username', None),
passexec_cmd=data.get('passexec_cmd', None),
passexec_expiration=data.get('passexec_expiration', None),
kerberos_conn=1 if data.get('kerberos_conn', False) else 0,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,10 @@ export default class ServerSchema extends BaseUISchema {
controlProps: { maxLength: 64},
mode: ['properties', 'create', 'edit'], deps: ['shared', 'username'],
readonly: (s)=>{
if(!this.origData.shared && s.shared) {
return false;
}
return true;
}, visible: (s)=>!obj.isShared(s),
return !(!this.origData.shared && s.shared);
}, visible: ()=>{
return current_user.is_admin && pgAdmin.server_mode == 'True';
},
depChange: (state, source, _topState, actionObj)=>{
let ret = {};
if(this.origData.shared) {
Expand Down
2 changes: 1 addition & 1 deletion web/pgadmin/dashboard/static/js/Dashboard.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ export default function Dashboard({
} else if (is_super_user) {
// Super user can do anything
return true;
} else if (current_user && current_user == treeNodeInfo.server.user?.name) {
} else if (current_user && current_user == row.original.usename) {
// Non-super user can cancel only their active queries
return true;
} else {
Expand Down

0 comments on commit 3a62fc5

Please sign in to comment.