[onnx] Reconstruct torch model from onnx doc_string #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
January 17, 2022 05:05
take-cheeze
requested review from
asi1024,
emcastillo and
kmaehashi
as code owners
take-cheeze
commented
Feb 9, 2022
| @@ -0,0 +1,97 @@ | |||
| import marko | |||
There was a problem hiding this comment.
To parse doc_string's markdown marko will be used
take-cheeze
commented
Feb 9, 2022
| @@ -421,7 +434,9 @@ def handle_if(self, g: torch._C.Graph, n: torch._C.Node) -> None: | |||
| # Generated onnx node doc string should be added later since DCE isn't completed yet | |||
| doc_str: str = f""" | |||
| ## Original node | |||
| ``` | |||
There was a problem hiding this comment.
Will be quoted for easier markdown parsing
take-cheeze
commented
Apr 5, 2023
| @@ -384,7 +384,7 @@ def _dump_upgraders_map() -> Dict[str, str]: ... | |||
| def _test_only_populate_upgraders(content: Dict[str, str]) -> None: ... | |||
| def _test_only_remove_upgraders(content: Dict[str, str]) -> None: ... | |||
| def merge_type_from_type_comment(decl: Decl, type_annotation_decl: Decl, is_method: _bool) -> Decl: ... | |||
| def parse_ir(input: str, parse_tensor_constants: _bool) -> Graph: ... | |||
| def parse_ir(input: str, parse_tensor_constants: _bool = False) -> Graph: ... | |||
There was a problem hiding this comment.
linshokaku
reviewed
Apr 10, 2023
added 2 commits
April 11, 2023 04:42
|
/test |
|
Hmm, cpu test seems to be running with torch-2.0. Let's fix that first |
|
Pre-review test seems still failing? |
|
/test |
|
https://ci.preferred.jp/pytorch-pfn-extras.torch113-linux/128554/261346#L1514 segv occured in pytest but seems to be a flaky behaviour |
|
/test |
linshokaku
previously approved these changes
Apr 26, 2023
kmaehashi
previously approved these changes
May 23, 2023
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v{v.unique()}to keep names same both in torch graph and onnx graphcheck_reconstructoption to onnx test utilities