Skip to content

Commit

Permalink
libzstd: also build with LIBZPOOL_CPPFLAGS
Browse files Browse the repository at this point in the history
libzstd now also allocates its own abd_t, and so has the same issue as
zstream did, so this applies the same workaround: compile it with
ZFS_DEBUG. See 92fca1c.

This looks weird, because libzstd doesn't appear to look related to the
ZFS kernel, but there is already a cross-dependency there: zstd needs
zfs_lz4_compress, and zfs needs zfs_zstd_compress (and others), so the
two can never really be separated without more work. Another job for
another time.

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed by: Brian Behlendorf <[email protected]>
Reviewed-by: Mark Maybee <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#16489
  • Loading branch information
robn authored and pfannc committed Nov 7, 2024
1 parent 1d2fab3 commit daea6be
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/libzstd/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
libzstd_la_CFLAGS = $(AM_CFLAGS) $(LIBRARY_CFLAGS)
libzstd_la_CPPFLAGS = $(AM_CPPFLAGS) $(LIBZPOOL_CPPFLAGS)

# -fno-tree-vectorize is set for gcc in zstd/common/compiler.h
# Set it for other compilers, too.
libzstd_la_CFLAGS += -fno-tree-vectorize
Expand Down

0 comments on commit daea6be

Please sign in to comment.