Add a color picker instead of a textbox for color selection #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I would like to suggest replacing the textbox with the browser color picker in
Other Options...
.To do this, simply change the type attribute in the textf element:
This simply replaces the
<input type="text">
element with a<input type="color">
element.The
<input type="color">
element accepts values in#rrggbb
hexadecimal format. For GWT there is no difference between thetype="color"
and thetype="text"
, so the getText() function in EditOptions.java:will return the value of the
value
attribute.Here’s how it looks in Chromium and Firefox:
Chromium has its own implementation of color selection:
Firefox seems to be using system libraries. Firefox on Windows:
Firefox on Linux:
I haven’t tested the implementation in Safari but according to the specification this element is supported by all browsers.
I hope that I managed to explain everything clearly with my not very good English.