Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uasyncio: Fixed bug in uasyncio.remove_writer #27

Closed
wants to merge 1 commit into from
Closed

uasyncio: Fixed bug in uasyncio.remove_writer #27

wants to merge 1 commit into from

Conversation

h3po
Copy link

@h3po h3po commented Feb 22, 2019

uselect.Epoll.unregister takes only one argument. I don't know what this code does and how it works (just started to use micropython) but I had to change this to make picoweb work.

uselect.Epoll.unregister takes only one argument. I don't know what this code does and how it works (just started to use micropython) but I had to change this to make picoweb work.
@pfalcon
Copy link
Owner

pfalcon commented Feb 22, 2019

You're using outdated MicroPython. Please read the docs: https://pypi.org/project/micropython-uasyncio/

@pfalcon pfalcon closed this Feb 22, 2019
@h3po
Copy link
Author

h3po commented Feb 22, 2019

i built it yesterday from pfalcon/micropython master branch. uasyncio and uselect from pypi
edit: ah, you're not using master. i see.

@h3po h3po deleted the patch-1 branch February 22, 2019 12:54
@pfalcon
Copy link
Owner

pfalcon commented Feb 22, 2019

master is upstream, i.e. micropython/micropython. You need to build from the default branch of the repo, which you get when you git clone https://github.com/pfalcon/micropython

@h3po
Copy link
Author

h3po commented Feb 22, 2019

yeah i was using a specific commit so i could build a release tag or latest. it just didn't occur to me that latest ist not master in this case.
I made a dockerfile to compile and run the unix port on a lightweight alpine image:
https://github.com/h3po/docker-micropython

@h3po
Copy link
Author

h3po commented Feb 22, 2019

I'm getting the same error with the pfalcon branch. Why do you think my micropython version is to blame?

micropython-lib/select/select.py

    def unregister(self, fd):

micropython-lib/uasyncio/uasyncio/init.py

    def remove_reader(self, sock):
    [...]
    self.poller.unregister(sock)

    def remove_writer(self, sock):
    [...]
    self.poller.unregister(sock, False)

@pfalcon
Copy link
Owner

pfalcon commented Feb 22, 2019

Because it's a known issue, hitting users not following the instructions, e.g. pfalcon/picoweb#45 .

Rather, you would need to explain why you think it's related to micropython-lib/select/select.py . And to be able to do something about this, there should be clear instructions how to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants